consistent TelegramError exceptions for Bot.getMe()#136
consistent TelegramError exceptions for Bot.getMe()#136jh0ker merged 10 commits intopython-telegram-bot:masterfrom
Conversation
|
Looks good! Don't forget to add your name to AUTHORS. |
|
@tsnoam the travis build is failing on |
|
@rahiel I added the test for a reason - in case of a not well formatted token, the error from the server will not be a json, but rather an html page (the documentation for the bot API). (and also I'll update the AUTHORS file) |
|
changes with the new PR:
|
|
pushed fix for python3... |
|
Hey, it seems like the unit tests fail for Python 2.6, because there is an assert function missing, that you're not using (there is no regexp in the String you're testing for, so you could just use All the other changes seem very neat, at a first glance! Thank you very much for your work :) |
debabf1 to
ef71de0
Compare
use custom _lstrip_str() func instead of regex. a little performance improvment and (IMO) a bit more readable.
|
@jh0ker
|
consistent TelegramError exceptions
|
Thank you very much, Noam! :) |
fixes #134