Closed
Conversation
Contributor
|
@dendisuhubdy why did you closed the PR? Any special reason?! |
Author
|
@diraol it didn't pass travis-ci build tests, I could reopen it if you want, and I didn't have time to resolve the conflicts (yet). |
Contributor
|
@dendisuhubdy try rebasing your branch against our |
dendisuhubdy
force-pushed
the
fix/import-imp
branch
from
65cd5f8 to
f94b0d7
Compare
Contributor
|
@dendisuhubdy did you created this branch based on the |
Author
|
@diraol I think so, I'm doing a reset --hard to the latest commit on the latest commit and rebasing it now |
dendisuhubdy
force-pushed
the
fix/import-imp
branch
from
f94b0d7 to
bb746d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding changes to address
impdeprecated since version 3.4. https://docs.python.org/3/library/imp.html