Fix multiple ref leaks when raising TypeError#31
Closed
tiran wants to merge 0 commit intopython-ldap:masterfrom
Closed
Fix multiple ref leaks when raising TypeError#31tiran wants to merge 0 commit intopython-ldap:masterfrom
tiran wants to merge 0 commit intopython-ldap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 62.35% 62.35% +<.01%
==========================================
Files 45 45
Lines 4362 4370 +8
Branches 735 737 +2
==========================================
+ Hits 2720 2725 +5
- Misses 1335 1337 +2
- Partials 307 308 +1
Continue to review full report at Codecov.
|
tiran
force-pushed
the
refleak_errcase
branch
from
3ae3b6a to
a72aaac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple functions had a reference leak while raising a TypeError with
Py_BuildValue(). The CAPI function Py_BuildValue() returns a new
reference. PyErr_SetObject() does NOT consume the reference. Instead it
increments the reference count of the object again.
A new function LDAPerror_TypeError() handles raising TypeError with
custom message and object.
Closes: #24
Signed-off-by: Christian Heimes cheimes@redhat.com