fix(projects): support approval_rules endpoint for projects#919
Merged
max-wittig merged 2 commits intopython-gitlab:masterfrom Oct 27, 2019
Merged
fix(projects): support approval_rules endpoint for projects#919max-wittig merged 2 commits intopython-gitlab:masterfrom
approval_rules endpoint for projects#919max-wittig merged 2 commits intopython-gitlab:masterfrom
Conversation
srikanthchelluri
force-pushed
the
project-approval-rules
branch
from
87b2552 to
c155782
Compare
Member
|
@srikanthchelluri Thanks for this MR! Would you mind to also add some tests for this feature? |
The `approvers` API endpoint is deprecated [1]. GitLab instead uses the `approval_rules` API endpoint to modify approval settings for merge requests. This adds the functionality for project-level merge request approval settings. Note that there does not exist an endpoint to 'get' a single approval rule at this moment - only 'list'. [1] https://docs.gitlab.com/ee/api/merge_request_approvals.html
srikanthchelluri
force-pushed
the
project-approval-rules
branch
from
c155782 to
cb4efcf
Compare
Contributor
Author
|
@max-wittig Force pushed to fix merge conflicts. It seems like merge request approvals aren't available in the community edition (which is what we're spinning up as part of the integration tests): https://gitlab.com/gitlab-org/gitlab/issues/20696 I added a few assertions to |
srikanthchelluri
force-pushed
the
project-approval-rules
branch
from
cb4efcf to
94bac44
Compare
Member
|
@srikanthchelluri ee-test.py seems like the place to put this, yes. I also don't have an EE version to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
approversAPI endpoint is deprecated [1]. GitLab instead usesthe
approval_rulesAPI endpoint to modify approval settings formerge requests. This adds the functionality for project-level
merge request approval settings.
Note that there does not exist an endpoint to 'get' a single
approval rule at this moment - only 'list'.
[1] https://docs.gitlab.com/ee/api/merge_request_approvals.html