Add new endpoint to get the variables of a pipeline#785
Merged
max-wittig merged 1 commit intopython-gitlab:masterfrom Jun 10, 2019
Merged
Conversation
agustinhenze
force-pushed
the
add-pipeline-get-variables-endpoint
branch
2 times, most recently
from
79a55f6 to
847ee7f
Compare
gpocentek
approved these changes
Jun 8, 2019
gpocentek
suggested changes
Jun 8, 2019
Contributor
gpocentek
left a comment
gpocentek
left a comment
There was a problem hiding this comment.
The patch looks good, thanks!
We have more strict commit message checks now, could you update it to something like:
feat: add endpoint to get the variables of a pipeline
Thanks!
It adds a new endpoint which was released in the Gitlab CE 11.11. Signed-off-by: Agustin Henze <tin@redhat.com>
agustinhenze
force-pushed
the
add-pipeline-get-variables-endpoint
branch
from
847ee7f to
564de48
Compare
Author
|
Thanks for the review :). Done, commit message changed |
gpocentek
approved these changes
Jun 10, 2019
|
Hi. Can you package a new version please? Thanks! |
Member
|
Sure. We will do so. Soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds a new endpoint which was released in the Gitlab CE 11.11.