Conversation
gpocentek
approved these changes
May 14, 2019
gpocentek
reviewed
May 14, 2019
Contributor
gpocentek
left a comment
gpocentek
left a comment
There was a problem hiding this comment.
It looks like something's broken, the file creation test is failing.
Member
Author
|
Yes. That's because of my merge in another merge request. See my revert of it. Then I need to rebase this. |
Member
Author
max-wittig
force-pushed
the
refactor/black
branch
2 times, most recently
from
edf4adb to
18f55ea
Compare
max-wittig
force-pushed
the
refactor/black
branch
from
18f55ea to
318d277
Compare
Member
Author
|
@gpocentek Pipeline passed now. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Black seems to become the defacto standard for python formatting.
A lot of projects are using it already: https://github.com/python/black#used-by
Fixes #772