X Tutup
Skip to content

Fix for #716: %d replaced by %s#729

Merged
max-wittig merged 1 commit intopython-gitlab:masterfrom
xarx00:PR-bugfix-716
Mar 6, 2019
Merged

Fix for #716: %d replaced by %s#729
max-wittig merged 1 commit intopython-gitlab:masterfrom
xarx00:PR-bugfix-716

Conversation

@xarx00
Copy link
Contributor

@xarx00 xarx00 commented Mar 5, 2019

This is a proposed fix for #716. While the id-s are integers when gitlab is used as a library, they are strings when used from the CLI.
Replacement of %d by %s should be safe.

@max-wittig
Copy link
Member

Thanks alot for your many contributions @xarx00. I will test and review them tomorrow.

@max-wittig max-wittig merged commit bc973d4 into python-gitlab:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup