Modify list method of UserProjectManager #669
Closed
carleski wants to merge 1 commit intopython-gitlab:masterfrom
carleski:userprojectfix
Closed
Modify list method of UserProjectManager #669carleski wants to merge 1 commit intopython-gitlab:masterfrom carleski:userprojectfix
carleski wants to merge 1 commit intopython-gitlab:masterfrom
carleski:userprojectfix
Conversation
Contributor
|
Hi @carleski Thanks for working on this! You patch works but I think it doesn't address the root problem. The user_id attribute should be discovered automatically. |
Member
|
@gpocentek What did you mean by automatically? |
|
Works for me: this patch let me list user's projects using symbolic user name (as well as numeric user's id). Why it doesnt merged yet ? |
Member
|
Merged in #886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...to use kwargs['user_id'] and self._parent.id
When running via CLI, as with
python-gitlab user-projects list --user-id 1, theself._parent.idvariable does not exist. However, the user id is passed through to the function askwargs['user_id']. This changes adds an if/else block to check to see ifself._parent.idexists, and then use the appropriate variable.