Add support for searching groups#55
Closed
dserodio wants to merge 2 commits intopython-gitlab:masterfrom
dserodio:search_groups
Closed
Add support for searching groups#55dserodio wants to merge 2 commits intopython-gitlab:masterfrom dserodio:search_groups
dserodio wants to merge 2 commits intopython-gitlab:masterfrom
dserodio:search_groups
Conversation
|
I agree with you Gauvain. It would be nice if these kind of 'search' functions are implemented directly in the classes (like Group or project). What do you think about this: A special class to do queries (we will have the possibility to choose between):
|
gpocentek
pushed a commit
that referenced
this pull request
Jan 9, 2016
Factorize the code to avoid duplication with the ProjectManager class. Implement unit tests for the group search. Original patchh from Daniel Serodio (PR #55).
Contributor
|
The code has changed recently and it's been easier to implement this method on the group manager. I pushed the change in commit 5513d0f. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can probably be improved, but works for my needs