Merged
Conversation
JohnVillalovos
force-pushed
the
jlvillal/version_gitlab_runner
branch
2 times, most recently
from
285208c to
8cb5939
Compare
The `latest` gitlab-runner image does not have the `gitlab-runner` user and it causes our tests to fail. Closes: #3091
JohnVillalovos
force-pushed
the
jlvillal/version_gitlab_runner
branch
from
8cb5939 to
553f5b0
Compare
JohnVillalovos
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
+ Coverage 93.57% 96.72% +3.14%
==========================================
Files 96 96
Lines 6291 6291
==========================================
+ Hits 5887 6085 +198
+ Misses 404 206 -198
Flags with carried forward coverage won't be shown. Click here to find out more. |
nejch
reviewed
Jan 22, 2025
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks @JohnVillalovos, looks good, just a question about the prints?
JohnVillalovos
force-pushed
the
jlvillal/version_gitlab_runner
branch
from
3010530 to
19573b4
Compare
nejch
reviewed
Jan 22, 2025
JohnVillalovos
force-pushed
the
jlvillal/version_gitlab_runner
branch
from
19573b4 to
bf0e534
Compare
Previously the 'job_with_artifact' fixture could run forever. Now give it up to 60 seconds to complete before failing.
JohnVillalovos
force-pushed
the
jlvillal/version_gitlab_runner
branch
from
bf0e534 to
5e169be
Compare
nejch
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
latestgitlab-runner image does not have thegitlab-runneruser and it causes our tests to fail.Closes: #3091