X Tutup
Skip to content

Fix tag api#307

Merged
gpocentek merged 3 commits intopython-gitlab:masterfrom
robberphex:fix-tag-api
Sep 11, 2017
Merged

Fix tag api#307
gpocentek merged 3 commits intopython-gitlab:masterfrom
robberphex:fix-tag-api

Conversation

@robberphex
Copy link
Contributor

  • Tag can get by id
  • on_http_error bring error_message, response_code, response_body



class ProjectTagManager(GetFromListMixin, CreateMixin, DeleteMixin,
class ProjectTagManager(GetMixin, CreateMixin, DeleteMixin,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the NoUpdateMixin instead of the 4 other mixins.

@gpocentek
Copy link
Contributor

Thanks!

The changes look good but you need to re-add the support for listing tags.

@gpocentek gpocentek merged commit fd40fce into python-gitlab:master Sep 11, 2017
@gpocentek
Copy link
Contributor

Thanks for the quick update!

@robberphex robberphex deleted the fix-tag-api branch September 11, 2017 12:19
@robberphex
Copy link
Contributor Author

please release new version. currently, v1.0.0 have this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup