feat(api): add project templates#3057
Merged
nejch merged 5 commits intopython-gitlab:mainfrom Dec 10, 2024
Merged
Conversation
gerry-pratama
changed the title
gerry-pratama
force-pushed
the
add-project-templates
branch
2 times, most recently
from
6d203b3 to
2056b2c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3057 +/- ##
==========================================
+ Coverage 96.64% 96.67% +0.02%
==========================================
Files 95 95
Lines 6142 6197 +55
==========================================
+ Hits 5936 5991 +55
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
Dec 8, 2024
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot for this @gerry-pratama, looks great! Just a nit on the naming and the tests, but I'm ok with this as well otherwise. These endpoints are definitely a bit funny on the GitLab side so makes sense to parametrize a bit.
gerry-pratama
force-pushed
the
add-project-templates
branch
from
2056b2c to
24af304
Compare
nejch
changed the title
nejch
approved these changes
Dec 10, 2024
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks again @gerry-pratama, looks great! I might squash this one as we use it for the changelog and users are mostly interested in the public API in the release notes. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Project template classes have been added to
objects/templates.pyand their respective managers added to the Project class inobjects/projects.pyto represent the project templates API.The project merge request template, in particular, will facilitate creating merge requests with a description template, like the following example:
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:
docs/gl_objects/templates.rst.docs/gl_objects/merge_requests.rsthas been updated to include an example of creating an MR with a default description template.tests/unit/objects/test_templates.pyhas been added to test both instance and project templates.