fix(files): correctly raise GitlabGetError in get method#3002
Merged
max-wittig merged 1 commit intomainfrom Sep 30, 2024
Merged
fix(files): correctly raise GitlabGetError in get method#3002max-wittig merged 1 commit intomainfrom
max-wittig merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 95 95
Lines 6087 6088 +1
=======================================
+ Hits 5881 5882 +1
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
@nejch Should we add a test for this somehow? |
Member
Author
|
@max-wittig I was also thinking about it initially, but not sure how we could do it explicitly while also covering other potential overrides. A simple test would only be for this specific case without adding more magic to collect all overrides. Otherwise we'd have to go more in the direction of tests in https://github.com/python-gitlab/python-gitlab/tree/main/tests/unit/meta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2998