fix: Have participants() method use http_list()#2914
Merged
Conversation
Previously it was using `http_get()` but the `participants` API returns a list of participants. Also by using this then we will warn if only a subset of the participants are returned. Closes: #2913
JohnVillalovos
force-pushed
the
jlvillal/participants_list
branch
from
165f848 to
fdee58f
Compare
The `closed_by()` and `related_merge_requests()` API calls return lists. So use the `http_list()` method. This will also warn the user if only a subset of the data is returned.
nejch
approved these changes
Jul 8, 2024
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks @JohnVillalovos!
Yes makes sense IMO this is why I'm in favor of using managers with ListMixin everywhere in place of custom methods as they often get it wrong or can get outdated it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was using
http_get()but theparticipantsAPI returns a list of participants. Also by using this then we will warn if only a subset of the participants are returned.Closes: #2913