Fix encoding errors on display and update with redirected output#27
Merged
gpocentek merged 2 commits intopython-gitlab:masterfrom Aug 21, 2014
Merged
Fix encoding errors on display and update with redirected output#27gpocentek merged 2 commits intopython-gitlab:masterfrom
gpocentek merged 2 commits intopython-gitlab:masterfrom
Conversation
When redirecting output to a file sys.stdout.encoding is None, so use sys.getdefaultencoding() instead.
When output is redirected sys.stdout.encoding is None. Fix this by always encoding to utf-8, assuming gitlab handles that. The encoding used by the local system is irrelevant here.
gpocentek
pushed a commit
that referenced
this pull request
Aug 21, 2014
Fix encoding errors on display and update with redirected output
Contributor
|
Thanks! |
This was referenced Aug 21, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried #26 and it did not work for me so I fixed it myself.
I use this inside a script for automatically posting bugs to gitlab.