fix(cli): fix action display in --help when there are few actions#2679
Merged
nejch merged 1 commit intopython-gitlab:mainfrom Oct 10, 2023
Merged
fix(cli): fix action display in --help when there are few actions#2679nejch merged 1 commit intopython-gitlab:mainfrom
nejch merged 1 commit intopython-gitlab:mainfrom
Conversation
nejch
approved these changes
Oct 10, 2023
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix @jouve, nice find.
I took the liberty of refactoring this a bit to be more readable (subjective of course!) and to fix a bug where the help indent was the length of all choices combined instead of the longest choice (which I think is the behavior you wanted. You're still set as the commit author of course. Hope that's alright with you! Thanks again!
Contributor
Author
|
no problem, I'd rather you do that than back and forth commits/ comments in the PR :) the length I used was to try to keep "Action to execute ..." from but I think your idea will look better. |
|
@nejch the find is mine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
display --help actions correctly when there are few actions.
fix #2656
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: