fix(cli): add _from_parent_attrs to user-project manager (#2558)#2588
Merged
nejch merged 2 commits intopython-gitlab:mainfrom Oct 12, 2023
Merged
fix(cli): add _from_parent_attrs to user-project manager (#2558)#2588nejch merged 2 commits intopython-gitlab:mainfrom
nejch merged 2 commits intopython-gitlab:mainfrom
Conversation
JohnVillalovos
force-pushed
the
fix-2558
branch
from
5984333 to
307338e
Compare
Codecov Report
@@ Coverage Diff @@
## main #2588 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 87 87
Lines 5656 5657 +1
=======================================
+ Hits 5450 5451 +1
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
force-pushed
the
fix-2558
branch
from
307338e to
0f1d0d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
setting
_from_parent_attrsonUserProjectManagerand using it in itslistmethod resolves #2558 and allows specific user's projects to be returned successfully.The inspiration for the fix came from
_from_parent_attrs = {"user_id": "id"}line ofUserProjectManager.Tested by running below script with arguments:
user-project list --user-id [user_id]