test: adapt functional tests for GitLab 15.8#2494
test: adapt functional tests for GitLab 15.8#2494JohnVillalovos wants to merge 4 commits intomainfrom
Conversation
|
@nejch If you want to explore the other tests that are failing due to the GitLab version bump feel free. Otherwise I will try to get to it tomorrow after I finish my work day. |
JohnVillalovos
force-pushed
the
jlvillal/password
branch
2 times, most recently
from
43c70c5 to
eb56aad
Compare
JohnVillalovos
force-pushed
the
jlvillal/password
branch
4 times, most recently
from
e5db411 to
aa413eb
Compare
nejch
changed the title
|
@JohnVillalovos I looked at the bulk import failures. It's now disabled by default with 15.8 on the instance and gives a cryptic 404 (filed it upstream: https://gitlab.com/gitlab-org/gitlab/-/issues/391545). I can try to tackle that as I worked on bulk imports.
But I havent looked at the user deletion issues yet. This might take a little more work to upgrade. |
|
@nejch Thanks for investigating. This is probably going to be a weekend project for me. |
Newer versions of GitLab will refuse to create a user with a weak password. In order for us to move to a newer GitLab version in testing use a stronger password for the tests that create a user.
Now GitLab is returning two custom attributes for a user. So don't assert that there are no custom attributes on a new user. [1] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/108250
Switch to newer version of GitLab for testing.
nejch
force-pushed
the
jlvillal/password
branch
from
aa413eb to
6fdaeff
Compare
nejch
force-pushed
the
jlvillal/password
branch
from
6fdaeff to
97e8044
Compare
|
I believe this was now merged as part of another PR. @JohnVillalovos if you think we missed something please reopen 🙇 (I know some parts are disabled at the moment, but still in the code). |
Agreed! Thanks. |
3 participants
No description provided.