fix: Use the ProjectIterationManager within the Project object#2404
Merged
nejch merged 1 commit intopython-gitlab:mainfrom Dec 3, 2022
Merged
fix: Use the ProjectIterationManager within the Project object#2404nejch merged 1 commit intopython-gitlab:mainfrom
nejch merged 1 commit intopython-gitlab:mainfrom
Conversation
The Project object was previously using the GroupIterationManager resulting in the incorrect API endpoint being used. Utilize the correct ProjectIterationManager instead. Resolves python-gitlab#2403
Codecov Report
@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 80 80
Lines 5342 5342
=======================================
Hits 5127 5127
Misses 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
approved these changes
Dec 3, 2022
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks for the catch @hollerdawg!
Note to self, this was probably an oversight when I added it initially because "project iterations" don't really exist anymore and associated group iterations are returned instead. So we might need to revisit this a bit if there's any kind of iteration-level endpoint later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Project object was previously using the GroupIterationManager resulting in the incorrect API endpoint being used. Utilize the correct ProjectIterationManager instead.
Resolves #2403