docs(api): pushrules remove saying None is returned when not found#2369
Merged
docs(api): pushrules remove saying None is returned when not found#2369
None is returned when not found#2369Conversation
nejch
reviewed
Nov 8, 2022
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks @JohnVillalovos, just a small question :)
In `groups.pushrules.get()`, GitLab does not return `None` when no rules are found. GitLab returns a 404. Update docs to not say it will return `None` Also update docs in `project.pushrules.get()` to be consistent. Not 100% sure if it returns `None` or returns a 404, but we don't need to document that. Closes: #2368
JohnVillalovos
force-pushed
the
jlvillal/push_rules
branch
from
7f851aa to
8c33c5b
Compare
nejch
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
groups.pushrules.get(), GitLab does not returnNonewhen no rules are found. GitLab returns a 404.Update docs to not say it will return
NoneAlso update docs in
project.pushrules.get()to be consistent. Not100% sure if it returns
Noneor returns a 404, but we don't need todocument that.
Closes: #2368