Provide API wrapper for cherry picking commits#236
Merged
gpocentek merged 8 commits intopython-gitlab:masterfrom Mar 21, 2017
cgumpert:cherry_pick_commit
Merged
Provide API wrapper for cherry picking commits#236gpocentek merged 8 commits intopython-gitlab:masterfrom cgumpert:cherry_pick_commit
gpocentek merged 8 commits intopython-gitlab:masterfrom
cgumpert:cherry_pick_commit
Conversation
gpocentek
suggested changes
Mar 17, 2017
Contributor
gpocentek
left a comment
gpocentek
left a comment
There was a problem hiding this comment.
Only 2 nitpicks, but the patch looks good. Could you make the minor changes and I'll merge.
Thank you!
docs/gl_objects/commits.rst
Outdated
| :start-after: # diff | ||
| :end-before: # end diff | ||
|
|
||
| Cherry-pick a commit into another branch |
Contributor
There was a problem hiding this comment.
Please end the line with a colon (:) to introduce the example.
gitlab/objects.py
Outdated
| GitlabCherryPickError: If the cherry pick could not be applied. | ||
| """ | ||
| url = '/projects/{0:s}/repository/commits/{1:s}/cherry_pick'.format( | ||
| self.project_id, self.id) |
Contributor
There was a problem hiding this comment.
For the sake of consistency could you use the old %()s format? Yes, this is nitpicking :)
Contributor
Author
There was a problem hiding this comment.
I had problems with keeping the line length below the limit of 79 characters. I worked around it now by introducing another local variable with a short name. If you have any other suggestion on how to break this string across two lines, I'd be happy to hear.
Contributor
|
Thank you for this patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible implementation for addressing #235. It allows to cherry pick individual commits through the Gitlab API both from the python code as well as from the command line. The documentation has been updated.