Conversation
|
@max-wittig @nejch can you review this PR please? Pretty similar to #2348 |
nejch
left a comment
There was a problem hiding this comment.
Looks great @abhiandthetruth thanks for the quick work again. Just a few quick notes :)
There is again a bit of replicated code from import_project function. Can't find a way to refactor it because it is quite small and creating any common entity just feals like overkill. Let me know if anyone has a way to go over it, else I think this much replication might be tolerable.
I agree, no need yet. We have plenty of other custom methods where this is an issue as well.
I think it would need a lot of rework but another decorator with required/optional payload attributes might make these methods more declarative instead of parsing args inside every method. Something like #1999 if we revive that at some point.
|
@nejch implemented the suggested changes. |
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot for this @abhiandthetruth, as you seem keen on contributing more later I added a small non-blocking note for a potential follow-up :) LGTM!
Closes #2356