feat(client): warn user on misconfigured URL in auth()#2222
Merged
JohnVillalovos merged 3 commits intomainfrom Aug 4, 2022
Merged
feat(client): warn user on misconfigured URL in auth()#2222JohnVillalovos merged 3 commits intomainfrom
auth()#2222JohnVillalovos merged 3 commits intomainfrom
Conversation
This was a quirk only present in GitLab 13.0 and fixed with 13.1. See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/33714 and https://gitlab.com/gitlab-org/gitlab/-/issues/218504 for more context.
nejch
force-pushed
the
feat/warn-user-misconfigured-url
branch
from
6f5b0e7 to
d71c1db
Compare
JohnVillalovos
approved these changes
Aug 4, 2022
Member
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Looks good. Thanks @nejch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1978.
3 steps here:
auth()so the user gets a warning ASAP.Other than that I haven't changed any of the
str/Nonehandling to keep thenext_urlcode the same in_query.