chore: remove broad Exception catching from config.py#2212
Conversation
28d51f8 to
1471c82
Compare
|
Thanks @JohnVillalovos! Just 2 questions. FWIW I recently realized we are rolling our own homebrew version of configparser (with all this try/except spaghetti) when python3's (and previously But probably not worth migrating that breaking change now that tomllib is coming to the stdlib and might be more attractivein the future to bring the config format in line with trends in the python world. |
1471c82 to
b70a438
Compare
Codecov Report
@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
- Coverage 95.43% 95.43% -0.01%
==========================================
Files 81 81
Lines 5369 5368 -1
==========================================
- Hits 5124 5123 -1
Misses 245 245
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b70a438 to
17dc79d
Compare
Change "except Exception:" catching to more granular exceptions. A step in enabling the "broad-except" check in pylint.
17dc79d to
0abc90b
Compare
|
Cool, I think we can get this in and double check if any new errors are thrown before the 28th :) |
Change "except Exception:" catching to more granular exceptions.
A step in enabling the "broad-except" check in pylint.