test(functional): bump GitLab docker image to 15.2.0-ee.0#2194
Merged
Conversation
Use the GitLab docker image 15.2.0-ee.0 in the functional testing.
nejch
reviewed
Jul 28, 2022
JohnVillalovos
force-pushed
the
jlvillal/update-gitlab
branch
3 times, most recently
from
f1603e2 to
3e07453
Compare
Codecov Report
@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
- Coverage 95.54% 95.49% -0.06%
==========================================
Files 81 81
Lines 5296 5344 +48
==========================================
+ Hits 5060 5103 +43
- Misses 236 241 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
force-pushed
the
jlvillal/update-gitlab
branch
from
3e07453 to
af47e74
Compare
In GitLab >= 15.0 `title` is required when creating a topic.
Cluster support was deprecated in GitLab 14.5 [1]. And disabled by default in GitLab 15.0 [2] * Update docs to mark clusters as deprecated * Remove testing of clusters [1] https://docs.gitlab.com/ee/api/project_clusters.html [2] https://gitlab.com/groups/gitlab-org/configure/-/epics/8
JohnVillalovos
force-pushed
the
jlvillal/update-gitlab
branch
from
af47e74 to
b46b379
Compare
nejch
reviewed
Jul 29, 2022
Comment on lines
+10
to
+18
| create_dict = {"name": "my-topic", "description": "My Topic"} | ||
| if gitlab_version.major >= 15: | ||
| create_dict["title"] = "my topic title" | ||
| topic = gl.topics.create( | ||
| {"name": "my-topic", "title": "my topic title", "description": "My Topic"} | ||
| ) | ||
| assert topic.name == "my-topic" | ||
| if gitlab_version.major >= 15: | ||
| assert topic.title == "my topic title" |
Member
There was a problem hiding this comment.
FWIW I don't think we need to test multiple major versions as tests get complicated quickly, but I agree it'll be helpful having version checks when developing new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the GitLab docker image 15.2.0-ee.0 in the functional testing.