Codecov Report

Merging #2069 (67942f0) into main (ca98d88) will increase coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
+ Coverage   94.64%   95.26%   +0.61%     
==========================================
  Files          78       78              
  Lines        5003     5003              
==========================================
+ Hits         4735     4766      +31     
+ Misses        268      237      -31     

Flags with carried forward coverage won't be shown. Click here to find out more.

@nejch Here is a first try to reach the 100% coverage for projects/push_rules objects 😄

🏓

Thanks a lot for all the work here @antoineauger open_mouth I left only some tiny comment but it's non-blocking. I think we can leave the duplicate for now as we have to do more cleanup in other parts.

I realize adding the response fixtures now is quite tedious, will probably need to think of some lightweight wrappers to make it more manageable.

Thanks for the valuable feedback @nejch, I think I addressed all your remarks. Back to you for final check 🏓