Conversation
Less confusing to have it be a normal method.
Naming a variable `what` makes it difficult to understand what it is used for. Rename it to `gitlab_resource` as that is what is being stored. The Gitlab documentation talks about them being resources: https://docs.gitlab.com/ee/api/api_resources.html This will improve code readability.
JohnVillalovos
force-pushed
the
jlvillal/resource
branch
from
81664b0 to
c86e471
Compare
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 78 78
Lines 4972 4972
=======================================
Hits 4700 4700
Misses 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Jun 4, 2022
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
I guess whaction should also be called resource_action then to match, if it doesn't get too verbose. But we can do that later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is based on top of PR: #2052
So can merge this and get both commits or merge #2052 first.
Naming a variable
whatmakes it difficult to understand what it isused for.
Rename it to
gitlab_resourceas that is what is being stored.The Gitlab documentation talks about them being resources:
https://docs.gitlab.com/ee/api/api_resources.html
This will improve code readability.