fix: remove custom delete method for labels#1868
Merged
Conversation
JohnVillalovos
force-pushed
the
jlvillal/delete_label
branch
3 times, most recently
from
3870af8 to
9c0d7a7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1868 +/- ##
==========================================
+ Coverage 92.35% 92.41% +0.05%
==========================================
Files 77 77
Lines 4856 4852 -4
==========================================
- Hits 4485 4484 -1
+ Misses 371 368 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Feb 1, 2022
nejch
approved these changes
Feb 1, 2022
The usage of deleting was incorrect according to the current API. Remove custom `delete()` method as not needed. Add tests to show it works with labels needing to be encoded. Also enable the test_group_labels() test function. Previously it was disabled. Add ability to do a `get()` for group labels. Closes: #1867
JohnVillalovos
force-pushed
the
jlvillal/delete_label
branch
from
9c0d7a7 to
0841a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage of deleting was incorrect according to the current API.
Remove custom
delete()method as not needed.Add tests to show it works with labels needing to be encoded.
Also enable the test_group_labels() test function. Previously it was
disabled.
Add ability to do a
get()for group labels.Closes: #1867