Enhance releases API docs for CI_JOB_TOKEN usage#1854
Merged
nejch merged 1 commit intopython-gitlab:mainfrom Jan 21, 2022
Merged
Enhance releases API docs for CI_JOB_TOKEN usage#1854nejch merged 1 commit intopython-gitlab:mainfrom
nejch merged 1 commit intopython-gitlab:mainfrom
Conversation
MRigal
force-pushed
the
docs/small-releases-additions
branch
from
3ff9d27 to
5d973de
Compare
Contributor
Author
|
Thanks @nejch for the review. My bad for the commit format, I had seen the pre-commit configs, but forgot to install the specific hook type, although precisely described here: https://github.com/python-gitlab/python-gitlab/blob/main/CONTRIBUTING.rst#development-workflow Hope this fits the expectation now and hope this can help someone else :-) |
nejch
approved these changes
Jan 21, 2022
Member
|
Looks great, thanks again @MRigal! If you find anything else that doesn't make sense feel free to contribute as well! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1850
@max-wittig @nejch willing to have a look on it?