X Tutup
Skip to content

Allow blank token in config #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
so0k wants to merge 1 commit into from
Closed

Allow blank token in config #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions gitlab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,12 @@ def auth(self):
def credentials_auth(self):
"""Performs an authentication using email/password."""
if not self.email or not self.password:
raise GitlabAuthenticationError("Missing email/password")
# raise GitlabAuthenticationError("Missing email/password")
data = json.dumps({'email':self.http_username,
'password':self.http_password})
else:
data = json.dumps({'email': self.email, 'password': self.password})

data = json.dumps({'email': self.email, 'password': self.password})
r = self._raw_post('/session', data, content_type='application/json')
raise_error_from_response(r, GitlabAuthenticationError, 201)
self.user = CurrentUser(self, r.json())
Expand Down
7 changes: 6 additions & 1 deletion gitlab/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def __init__(self, gitlab_id=None, config_files=None):

try:
self.url = self._config.get(self.gitlab_id, 'url')
self.token = self._config.get(self.gitlab_id, 'private_token')
except Exception:
raise GitlabDataError("Impossible to get gitlab informations from "
"configuration (%s)" % self.gitlab_id)
Expand All @@ -79,6 +78,12 @@ def __init__(self, gitlab_id=None, config_files=None):
except Exception:
pass

self.token = None
try:
self.token = self._config.get(self.gitlab_id, 'private_token')
except Exception:
pass

self.http_username = None
self.http_password = None
try:
Expand Down
X Tutup