chore: make Gitlab.http_request() a private method#1842
Closed
JohnVillalovos wants to merge 1 commit intomainfrom
Closed
chore: make Gitlab.http_request() a private method#1842JohnVillalovos wants to merge 1 commit intomainfrom
Gitlab.http_request() a private method#1842JohnVillalovos wants to merge 1 commit intomainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
Gitlab.http_request()toGitlab._http_request()to signifyit is a private/protected method so that users of the library know
they should not use the method and we make no API stability promises
for using it.
Add a
Gitlab.http_request()method which will issue a Deprecationwarning when called. It will pass the call onto
Gitlab._http_request()Also, in the interest of improving code read-ability, require keyword
arg usage when calling
Gitlab._http_request()