fix: change to http_list for some ProjectCommit methods#1809
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1809 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 76 76
Lines 4790 4791 +1
=======================================
+ Hits 4408 4409 +1
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
force-pushed
the
jlvillal/list_api
branch
from
9b3db93 to
8b4f500
Compare
Member
|
@JohnVillalovos I'd say this is a proper fix and not a chore especially as it fixes that older issue as well, could you change the commit message so we can trigger a fix release? |
JohnVillalovos
force-pushed
the
jlvillal/list_api
branch
from
8b4f500 to
497e860
Compare
JohnVillalovos
changed the title
http_list for some ProjectCommit methods
Member
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the type-hints and use
http_list()for the ProjectCommits methods:This will enable using the pagination support we have for lists.
Closes: #1805
Closes: #1231