feat: package file delete on package file object#1733
feat: package file delete on package file object#1733nejch merged 1 commit intopython-gitlab:mainfrom shebertd:fix-package-file-delete
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1733 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 75 75
Lines 4689 4689
=======================================
Hits 4312 4312
Misses 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks. Would you be willing to add a test case for this? Probably in |
|
@JohnVillalovos I will! |
|
@JohnVillalovos I've added a unit tests and classified the merge as a |
|
@JohnVillalovos I've fixed my test. I like the setup of the project with commitlint. |
|
Thanks. As a note for the future. It can sometimes be simpler to do the tests in the But thanks for the unit tests! |
|
Thanks for your precious time. I will note that! As a fact I will revisit the functional test in the future to help me learn pytest and be more confident in the delete at the same time. My delete is'nt a great test because it only test if it does'nt work, but not if it works. |
|
Thank you very much @simonisateur! |
No description provided.