@nejch Thanks for the info above. If you have any ideas why my change is failing it would be appreciated. I guess I could just drop using the decorator as it seems to work okay without it. But I think it is using "in-process" mode by default instead of "subprocess" mode. Not sure if that matters or not.

@nejch Thanks for the info above. If you have any ideas why my change is failing it would be appreciated. I guess I could just drop using the decorator as it seems to work okay without it. But I think it is using "in-process" mode by default instead of "subprocess" mode. Not sure if that matters or not.

@nejch I got it figured out. Ready for review. Thanks.

@nejch Thanks for the info above. If you have any ideas why my change is failing it would be appreciated. I guess I could just drop using the decorator as it seems to work okay without it. But I think it is using "in-process" mode by default instead of "subprocess" mode. Not sure if that matters or not.

@nejch I got it figured out. Ready for review. Thanks.

Thanks @JohnVillalovos. I hope my comment wasn't too confusing. What you did in tox.ini would also work, I just wanted to say it was not needed for py_func_v4 (hence the failure as it wasnt using the scripts plugin), but only cli_func_v4. What you did here also works but is maybe less scalable as we need to do it for every module instead of the entire suite. So I'll leave it up to you, I'd say you could still add:

[testenv:cli_func_v4]
deps = -r{toxinidir}/requirements-docker.txt
commands =
  pytest --script-launch-mode=subprocess --cov --cov-report xml tests/functional/cli {posargs}

and it would work (but omit it for py_func_v4).

The reason I added subprocess mode initially I think was because it would more closely resemble the environment of a user running the CLI I believe.

Thanks @JohnVillalovos. I hope my comment wasn't too confusing. What you did in tox.ini would also work, I just wanted to say it was not needed for py_func_v4 (hence the failure as it wasnt using the scripts plugin), but only cli_func_v4. What you did here also works but is maybe less scalable as we need to do it for every module instead of the entire suite. So I'll leave it up to you, I'd say you could still add:

Thanks @nejch When I got the error before when using the command line argument --script-launch-mode=subprocess I just went and worked around it. I didn't realize that the reason it failed in py_func_v4 was because it wasn't using the plugin. I knew it was being installed so I assumed the command line argument should also work. I'm guessing that if it doesn't use the plugin then the command-line plugin arguments don't get added.