chore: enforce type-hints on most files in gitlab/v4/objects/#1680
Merged
chore: enforce type-hints on most files in gitlab/v4/objects/#1680
Conversation
JohnVillalovos
force-pushed
the
jlvillal/mypy_small_files_1
branch
from
68cafa0 to
59d1bde
Compare
Codecov Report
@@ Coverage Diff @@
## main #1680 +/- ##
==========================================
- Coverage 91.95% 91.86% -0.09%
==========================================
Files 75 75
Lines 4364 4427 +63
==========================================
+ Hits 4013 4067 +54
- Misses 351 360 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Nov 8, 2021
JohnVillalovos
force-pushed
the
jlvillal/mypy_small_files_1
branch
from
59d1bde to
5523f6a
Compare
* Add type-hints to some of the files in gitlab/v4/objects/
* Fix issues detected when adding type-hints
* Changed mypy exclusion to explicitly list the 13 files that have
not yet had type-hints added.
JohnVillalovos
force-pushed
the
jlvillal/mypy_small_files_1
branch
from
5523f6a to
7828ba2
Compare
nejch
approved these changes
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not yet had type-hints added.