chore: add type-hints to multiple files in gitlab/v4/objects/#1674
Merged
chore: add type-hints to multiple files in gitlab/v4/objects/#1674
Conversation
JohnVillalovos
force-pushed
the
jlvillal/mypy_small_files_1
branch
from
cabf613 to
288121d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1674 +/- ##
==========================================
- Coverage 91.97% 91.95% -0.03%
==========================================
Files 75 75
Lines 4351 4364 +13
==========================================
+ Hits 4002 4013 +11
- Misses 349 351 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add and/or check type-hints for the following files
gitlab.v4.objects.access_requests
gitlab.v4.objects.applications
gitlab.v4.objects.broadcast_messages
gitlab.v4.objects.deployments
gitlab.v4.objects.keys
gitlab.v4.objects.merge_trains
gitlab.v4.objects.namespaces
gitlab.v4.objects.pages
gitlab.v4.objects.personal_access_tokens
gitlab.v4.objects.project_access_tokens
gitlab.v4.objects.tags
gitlab.v4.objects.templates
gitlab.v4.objects.triggers
Add a 'get' method with the correct type for Managers derived from
GetMixin.
JohnVillalovos
force-pushed
the
jlvillal/mypy_small_files_1
branch
from
288121d to
8b75a77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add and/or check type-hints for the following files
gitlab.v4.objects.access_requests
gitlab.v4.objects.applications
gitlab.v4.objects.broadcast_messages
gitlab.v4.objects.deployments
gitlab.v4.objects.keys
gitlab.v4.objects.merge_trains
gitlab.v4.objects.namespaces
gitlab.v4.objects.pages
gitlab.v4.objects.personal_access_tokens
gitlab.v4.objects.project_access_tokens
gitlab.v4.objects.tags
gitlab.v4.objects.templates
gitlab.v4.objects.triggers
Add a 'get' method with the correct type for Managers derived from
GetMixin.