Codecov Report

Merging #1641 (f41b093) into main (5a1678f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   91.90%   91.93%   +0.02%     
==========================================
  Files          74       74              
  Lines        4287     4302      +15     
==========================================
+ Hits         3940     3955      +15     
  Misses        347      347              

Flags with carried forward coverage won't be shown. Click here to find out more.

The CI failure appears to be unrelated to this change?

Thanks for the PR. It would be great if there can be some tests for this, assuming it is a "Free Tier" feature.

Thanks for the PR. It would be great if there can be some tests for this, assuming it is a "Free Tier" feature.

It's a premium feature since 13.9. I was prepared to add unit tests, but I noticed that "merge request approvals" doesn't have any to begin with.

Thanks for the PR. It would be great if there can be some tests for this, assuming it is a "Free Tier" feature.

It's a premium feature since 13.9. I was prepared to add unit tests, but I noticed that "merge request approvals" doesn't have any to begin with.

Hi @JacobHenner, thanks for this! As @JohnVillalovos said, we won't be able to add functional tests without a license but we can have some unit tests maybe.

Maybe in https://github.com/python-gitlab/python-gitlab/blob/main/tests/unit/objects/test_project_merge_request_approvals.py?
Just a simple get() call and mock response to make sure we keep sending the right request. Thanks again for the super clean PR!