feat(api): add project label promotion#1610
Conversation
StingRayZA
force-pushed
the
add-label-promote
branch
from
9e6f705 to
c26b619
Compare
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
+ Coverage 91.57% 91.61% +0.03%
==========================================
Files 74 74
Lines 4263 4294 +31
==========================================
+ Hits 3904 3934 +30
- Misses 359 360 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks for this. This is going to need some docs updates too, so that people know it is there and also how to use it. |
|
Sure - will add them now the CI has given the code a 👍 |
StingRayZA
force-pushed
the
add-label-promote
branch
from
c26b619 to
76715a5
Compare
|
I've removed the CLI action (It wasn't testing well, and I don't think I know how to make it work without breaking backwards compatibility) Also added a note into the docs... |
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thank you @StingRayZA! I just had a few questions.
I'm unsure if /promote is an endpoint that will appear elsewhere and warrant its own Mixin, but it looks clean this way :)
|
Thanks for the review @nejch - I've got a tweak or two to make and I'll post them ASAP... |
StingRayZA
force-pushed
the
add-label-promote
branch
from
76715a5 to
68ba4b7
Compare
|
Thanks again @StingRayZA. Just a nitpick for tests and if you could maybe rebase on top of |
Adds a mixin that allows the /promote endpoint to be called. Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
StingRayZA
force-pushed
the
add-label-promote
branch
from
68ba4b7 to
6d7c88a
Compare
|
All done @nejch - updated and rebased 😁 |
|
Thanks for the contribution @StingRayZA! :) Looking forward to the milestone PR 😁 |
4 participants
Adds a mixin that allows the
/promoteendpoint to be called on project labels.Fixes #1602