fix: functional project service test#1500
Merged
nejch merged 3 commits intopython-gitlab:masterfrom Jun 9, 2021
JohnVillalovos:jlvillal/func_project
Merged
fix: functional project service test#1500nejch merged 3 commits intopython-gitlab:masterfrom JohnVillalovos:jlvillal/func_project
nejch merged 3 commits intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/func_project
Conversation
The PR: #1462 was not able to merge due to a change in the latest version of Gitlab. More details here: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61646 Update the functional test to first create the project service before doing a get.
Member
Author
|
@benjamb Since you pointed out the issue, I wanted to bring this to your attention. |
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
- Coverage 91.04% 82.17% -8.88%
==========================================
Files 74 74
Lines 4145 4145
==========================================
- Hits 3774 3406 -368
- Misses 371 739 +368
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
@JohnVillalovos Nice one, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bring in the two commits from #1462