feat: add keys endpoint#1490
feat: add keys endpoint#1490nejch merged 1 commit intopython-gitlab:masterfrom benjamb:benbrown/keys
Conversation
|
On a somewhat unrelated note, is there a reason flake8 isn't included in the pre-commit config? |
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 91.01% 91.04% +0.03%
==========================================
Files 73 74 +1
Lines 4128 4145 +17
==========================================
+ Hits 3757 3774 +17
Misses 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Good catch. @nejch recently updated it to add |
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
I'd like @nejch and/or @max-wittig to also look.
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot, looks great! Just 2 tiny comments :)
gitlab/v4/objects/keys.py
Outdated
| return super(KeyManager, self).get(id, **kwargs) | ||
|
|
||
| if "fingerprint" not in kwargs: | ||
| raise AttributeError("Missing attribute: fingerprint") |
There was a problem hiding this comment.
This should probably have both options:
| raise AttributeError("Missing attribute: fingerprint") | |
| raise AttributeError("Missing attribute: id or fingerprint") |
Yes, these were just very recent additions to CI checks but we should add pre-commit as well. |
4 participants
While this endpoint may be a little niche, it was useful for a project I was involved in recently.