chore: make certain dotfiles searchable by ripgrep#1475
Merged
nejch merged 1 commit intopython-gitlab:masterfrom May 29, 2021
JohnVillalovos:jlvillal/gitignore
Merged
chore: make certain dotfiles searchable by ripgrep#1475nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/gitignore
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/gitignore
Conversation
nejch
requested changes
May 29, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks! I have a feeling we might forget to maintain this list, but it can't hurt 😀 Maybe this can be improved by reducing dotfile clutter also, a few more tools now support pyproject.toml and some stuff can go in .github/, I'll push a follow-up PR.
Just saw we're missing a few entries though.
By explicitly NOT excluding the dotfiles we care about to the .gitignore file we make those files searchable by tools like ripgrep. By default dotfiles are ignored by ripgrep and other search tools (not grep)
Codecov Report
@@ Coverage Diff @@
## master #1475 +/- ##
==========================================
- Coverage 90.91% 86.37% -4.54%
==========================================
Files 73 73
Lines 4051 4052 +1
==========================================
- Hits 3683 3500 -183
- Misses 368 552 +184
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
approved these changes
May 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By explicitly NOT excluding the dotfiles we care about to the
.gitignore file we make those files searchable by tools like ripgrep.
By default dotfiles are ignored by ripgrep and other search tools (not
grep)