chore: add isort as a checker#1463
Merged
nejch merged 2 commits intopython-gitlab:masterfrom May 25, 2021
JohnVillalovos:jlvillal/isort
Merged
chore: add isort as a checker#1463nejch merged 2 commits intopython-gitlab:masterfrom JohnVillalovos:jlvillal/isort
nejch merged 2 commits intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/isort
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 90.83% 90.85% +0.02%
==========================================
Files 73 73
Lines 4027 4037 +10
==========================================
+ Hits 3658 3668 +10
Misses 369 369
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Add an isort tox environment * Run the isort tox environment using --check in the Github CI https://pycqa.github.io/isort/
nejch
reviewed
May 24, 2021
Member
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Nice, finally don't need to worry about whether the first 10 lines in new files make sense 😁 Just have a few thoughts.
Fix the import ordering using isort. https://pycqa.github.io/isort/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isort is a tool to make sure that imports are ordered correctly.
Add a tox environment for it and also add it to the Github workflow to
ensure it is checked for Pull Requests.
Run isort on all the code and commit changes it made.
https://pycqa.github.io/isort/