feat(objects): add support for generic packages API#1460
Merged
JohnVillalovos merged 2 commits intomasterfrom Jun 1, 2021
Merged
feat(objects): add support for generic packages API#1460JohnVillalovos merged 2 commits intomasterfrom
JohnVillalovos merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1460 +/- ##
==========================================
+ Coverage 90.92% 91.01% +0.08%
==========================================
Files 73 73
Lines 4056 4107 +51
==========================================
+ Hits 3688 3738 +50
- Misses 368 369 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
force-pushed
the
feat/generic-packages
branch
from
0af668f to
fadc681
Compare
nejch
force-pushed
the
feat/generic-packages
branch
from
fadc681 to
9b4cc2c
Compare
JohnVillalovos
requested changes
May 30, 2021
Co-authored-by: John Villalovos <john@sodarock.com>
nejch
force-pushed
the
feat/generic-packages
branch
from
0c271b7 to
64e8d57
Compare
nejch
commented
May 31, 2021
Member
Author
nejch
left a comment
nejch
left a comment
There was a problem hiding this comment.
Thanks! :) I've applied all the typing suggestions, for enforcing keyword arguments we can maybe discuss separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1389.
I had to add a
rawparam to put/post like we have for get, instead of usingfileswith the multipart encoder, to really ensure only the raw data ended up as the uploaded package 🤔Maybe it's just how
filesare handled currently and can still be refactored to take out redundant stuff if we want a raw upload. In the meantime I also cleaned out some code fromhttp_requestinto a helper method and centralized the content_types there (http_requestwould be getting quite long and messy otherwise).