chore(docs): fix import order for readthedocs build#1442
Merged
JohnVillalovos merged 1 commit intomasterfrom May 1, 2021
Merged
chore(docs): fix import order for readthedocs build#1442JohnVillalovos merged 1 commit intomasterfrom
JohnVillalovos merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
=======================================
Coverage 80.24% 80.24%
=======================================
Files 73 73
Lines 4064 4064
=======================================
Hits 3261 3261
Misses 803 803
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
JohnVillalovos
approved these changes
May 1, 2021
Member
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Makes sense. Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts b498ebd. I noticed the builds are failing on RTD right now and it started with this commit.
Turns out RTD does not have
gitlabin path because it does its own weird build, so we really need this hack. Here's requests doing the same: https://github.com/psf/requests/blob/c45a4dfe6bfc6017d4ea7e9f051d6cc30972b310/docs/conf.py#L23-L27There might be cleaner solutions but if
psfrepos do it, I guess this is ok 🤣