test(functional): start tracking functional test coverage#1440
test(functional): start tracking functional test coverage#1440JohnVillalovos merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
+ Coverage 80.24% 89.41% +9.17%
==========================================
Files 73 73
Lines 4064 4064
==========================================
+ Hits 3261 3634 +373
+ Misses 803 430 -373
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
WDYT? I wanted to get a whole overview of what code covered by tests, including functional. Using flags you can really nicely split the suites in codecov, see https://codecov.io/gh/python-gitlab/python-gitlab/src/f875786ce338b329421f772b181e7183f0fcb333/gitlab/v4/cli.py I think in docker tests the real bottleneck is the docker container, so I thought it wouldn't hurt adding XML coverage to the runs by default. Most people run unit tests locally I assume. I also tweaked the codecov commenter a bit as it's not very helpful getting spammed with the comment if there's no change in coverage. |
JohnVillalovos
left a comment
There was a problem hiding this comment.
Looks good to me. I like it.
Thanks.
Trying out codecov flags to see how much the whole suite covers.