chore: have flake8 check the entire project#1429
chore: have flake8 check the entire project#1429max-wittig merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/flake8
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
=======================================
Coverage 80.24% 80.24%
=======================================
Files 73 73
Lines 4064 4064
=======================================
Hits 3261 3261
Misses 803 803
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
max-wittig
left a comment
max-wittig
left a comment
There was a problem hiding this comment.
Nice catch!
Do we need to assign variables that we're not using to _?
No. The only reason I had for doing that was to make it clear that the call returns something. I was undecided if I should just delete the assignment or use But I will re-do it and delete the assignments. |
|
If we want to check, if it's returning something we should assert instead. But I think this is already checked somewhere else. You can also apply the suggestions and I squash after, if you like 😃 |
Have flake8 run at the top-level of the projects instead of just the gitlab directory.
|
@max-wittig Updated. I think I have changed everything as requested. |
3 participants
Have flake8 run at the top-level of the projects instead of just the
gitlab directory.