chore: make Get.*Mixin._optional_get_attrs always present#1412
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Apr 26, 2021
JohnVillalovos:jlvillal/optional_get_attrs
Merged
chore: make Get.*Mixin._optional_get_attrs always present#1412nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/optional_get_attrs
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/optional_get_attrs
Conversation
Always create GetMixin/GetWithoutIdMixin._optional_get_attrs attribute with a default value of tuple() This way we don't need to use hasattr() and we will know the type of the attribute.
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
=======================================
Coverage 80.20% 80.21%
=======================================
Files 73 73
Lines 4067 4068 +1
=======================================
+ Hits 3262 3263 +1
Misses 805 805
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnVillalovos
changed the title
nejch
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always create GetMixin/GetWithoutIdMixin._optional_get_attrs attribute
with a default value of tuple()
This way we don't need to use hasattr() and we will know the type of
the attribute.