chore: mypy: Disallow untyped definitions#1409
Merged
nejch merged 1 commit intopython-gitlab:masterfrom May 1, 2021
JohnVillalovos:jlvillal/untyped_defs
Merged
chore: mypy: Disallow untyped definitions#1409nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/untyped_defs
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/untyped_defs
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 80.24% 80.26% +0.01%
==========================================
Files 73 73
Lines 4064 4073 +9
==========================================
+ Hits 3261 3269 +8
- Misses 803 804 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnVillalovos
changed the title
max-wittig
reviewed
Apr 25, 2021
Member
|
Just a small question |
Member
Author
@max-wittig I think I answered your question, but let me know if you need more information. Thanks |
nejch
reviewed
Apr 26, 2021
Be more strict and don't allow untyped definitions on the files we check. Also this adds type-hints for two of the decorators so that now functions/methods decorated by them will have their types be revealed correctly.
nejch
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be more strict and don't allow untyped definitions on the files we
check.
Also this adds type-hints for two of the decorators so that now
functions/methods decorated by them will have their types be revealed
correctly.