fix: correct ProjectFile.decode() documentation#1405
Merged
max-wittig merged 1 commit intopython-gitlab:masterfrom Apr 23, 2021
JohnVillalovos:jlvillal/returns_bytes
Merged
fix: correct ProjectFile.decode() documentation#1405max-wittig merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/returns_bytes
max-wittig merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/returns_bytes
Conversation
JohnVillalovos
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 73 73
Lines 4071 4071
=======================================
Hits 3266 3266
Misses 805 805
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ProjectFile.decode() returns 'bytes' and not 'str'. Update the method's doc-string and add a type-hint. ProjectFile.decode() returns the result of a call to base64.b64decode() The docs for that function state it returns 'bytes': https://docs.python.org/3/library/base64.html#base64.b64decode Fixes: #1403
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectFile.decode() returns 'bytes' and not 'str'.
Update the method's doc-string and add a type-hint.
ProjectFile.decode() returns the result of a call to
base64.b64decode()
The docs for that function state it returns 'bytes':
https://docs.python.org/3/library/base64.html#base64.b64decode
Fixes: #1403