chore(api): move repository endpoints into separate module#1347
Merged
max-wittig merged 1 commit intomasterfrom Feb 28, 2021
Merged
chore(api): move repository endpoints into separate module#1347max-wittig merged 1 commit intomasterfrom
max-wittig merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
+ Coverage 80.19% 80.21% +0.02%
==========================================
Files 72 73 +1
Lines 3786 3790 +4
==========================================
+ Hits 3036 3040 +4
Misses 750 750
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
I guess we don't need the depreciation warning. The next release is gonna be called 3.0.0 anyway. We already did a couple of breaking changes and that would make more sense, instead of maintaining the old behaviour. We're just a small library. People who don't want to switch can stay on the 2.X version. |
Member
|
Looks very good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep work for #1306 because
projects.pyis getting bloated again already (I'm splitting this into two PRs just for clarity).I noticed all the
/repository/endpoints were just kind of slapped into the project manager as custom methods. For now this just splits the methods into a separate Mixin, but perhaps later namespacing them with a separate manager would make it cleaner:The old methods could then just call the manager, and maybe raise a deprecation warning.
WDYT @max-wittig would that make sense? I'd open a follow-up later for the repository manager.